[Bigbang-dev] request for code review

[Sebastian Benthall]

Thanks for this discussion!
Yes, let's do this.
Code reviews also are good because they broaden familiarity with the code
across the community.
Reduces bus factor.

On Mon, Oct 24, 2016 at 10:43 AM, Harsh Gupta <mail at hargup.in> wrote:

> > So you think no one should make commits, but only open PRs which should
> be reviewed?
>
> +1, we also use this policy in SymPy [1] and I feel that encourages
> people to review other's work.
>
> > alias yolo='git commit -am "Deal with it" && git push -f origin master'
>
> Force push can really mess things up when multiple people are working on
> the same repo simultaneously. Say you pulled the master a certain state,
> then I pushed some changes to it and then  if you force push without
> pulling again, my intermediate commits will be lost. You can the setting
> of the repo to prevent force push and I think we should use them. (See
> https://help.github.com/articles/about-protected-branches/)
>
> The repo can also be configure to make pull requests a requirement to
> commit to master.
>
> [1]: https://github.com/sympy/sympy/
>
> --
>   Harsh Gupta
>   mail at hargup.in
>
> On Mon, Oct 24, 2016, at 09:19 AM, Niels ten Oever wrote:
> > Done.
> >
> > So you think no one should make commits, but only open PRs which should
> > be reviewed?
> >
> > I think we could give this a try. I am also one of the bad people who
> > always pushes to master (alias yolo='git commit -am "Deal with it" &&
> > git push -f origin master' ;) )
> >
> >
> > Cheers,
> >
> > Niels
> >
> > Niels ten Oever
> > Head of Digital
> >
> > Article 19
> > www.article19.org
> >
> > PGP fingerprint    8D9F C567 BEE4 A431 56C4
> >                    678B 08B5 A0F2 636D 68E9
> >
> > On 10/24/2016 10:09 AM, Sebastian Benthall wrote:
> > > Hi all,
> > >
> > > I must ask for one of you to do a code review for me, please.
> > >
> > > I made a stupid mistake over the weekend while being too hasty to make
> > > some changes. I've explained my mistake here:
> > >
> > > https://github.com/datactive/bigbang/issues/275
> > >
> > > I have filed a pull request to fix the mistake I made, but since the
> > > real mistake was hastily making a change without asking somebody to
> > > check my work, I have to correct that as well.
> > >
> > > Would one of you please look over this pull request and, if it looks OK
> > > to you, merge it?
> > >
> > > https://github.com/datactive/bigbang/pull/276
> > >
> > > Thanks!
> > >
> > > Seb
> > >
> > >
> > > _______________________________________________
> > > Bigbang-dev mailing list
> > > Bigbang-dev at data-activism.net
> > > https://lists.ghserv.net/mailman/listinfo/bigbang-dev
> > >
> >
> > _______________________________________________
> > Bigbang-dev mailing list
> > Bigbang-dev at data-activism.net
> > https://lists.ghserv.net/mailman/listinfo/bigbang-dev
> > Email had 1 attachment:
> > + signature.asc
> >   1k (application/pgp-signature)
>
> _______________________________________________
> Bigbang-dev mailing list
> Bigbang-dev at data-activism.net
> https://lists.ghserv.net/mailman/listinfo/bigbang-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ghserv.net/pipermail/bigbang-dev/attachments/20161024/15e43df9/attachment-0001.html>