[Bigbang-dev] request for code review

[Niels ten Oever]

Done.

So you think no one should make commits, but only open PRs which should
be reviewed?

I think we could give this a try. I am also one of the bad people who
always pushes to master (alias yolo='git commit -am "Deal with it" &&
git push -f origin master' ;) )


Cheers,

Niels

Niels ten Oever
Head of Digital

Article 19
www.article19.org

PGP fingerprint    8D9F C567 BEE4 A431 56C4
                   678B 08B5 A0F2 636D 68E9

On 10/24/2016 10:09 AM, Sebastian Benthall wrote:
> Hi all,
> 
> I must ask for one of you to do a code review for me, please.
> 
> I made a stupid mistake over the weekend while being too hasty to make
> some changes. I've explained my mistake here:
> 
> https://github.com/datactive/bigbang/issues/275
> 
> I have filed a pull request to fix the mistake I made, but since the
> real mistake was hastily making a change without asking somebody to
> check my work, I have to correct that as well.
> 
> Would one of you please look over this pull request and, if it looks OK
> to you, merge it?
> 
> https://github.com/datactive/bigbang/pull/276
> 
> Thanks!
> 
> Seb
> 
> 
> _______________________________________________
> Bigbang-dev mailing list
> Bigbang-dev at data-activism.net
> https://lists.ghserv.net/mailman/listinfo/bigbang-dev
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ghserv.net/pipermail/bigbang-dev/attachments/20161024/30306ef8/attachment.sig>